Re: [2.6 patch] m68k: remove the dead PCI code
From: Geert Uytterhoeven
Date: Wed Sep 03 2008 - 03:23:12 EST
On Sun, 31 Aug 2008, Adrian Bunk wrote:
> On Fri, Aug 29, 2008 at 09:31:43AM +0200, Geert Uytterhoeven wrote:
> > On Fri, 29 Aug 2008, Adrian Bunk wrote:
> > > On Fri, Aug 29, 2008 at 02:13:24PM +1000, Greg Ungerer wrote:
> > > > Adrian Bunk wrote:
> > > >> A patch for removing the comempci code is below.
> > > >>
> > > >> It's a bit suspicious that asm/elia.h is now removed since comempci.c
> > > >> was the only user. What's the sttus of the eLIA platform?
> > > >
> > > > Only ever a handful where made, and that was in 1999.
> > > > I doubt anyone could ever use the PCI interface on it
> > > > in any useful way.
> > >
> > > So I can send a patch to remove the platform?
> > >
> > > >> But COMEMPCI fails with a different error - this init/main.o build
> > > >> error is present for CONFIG_PCI=y, CONFIG_COMEMPCI=n, so the dependency
> > > >> of PCI on BROKEN is still required (unless it gets fixed).
> > > >
> > > > Unless I am mistaken there is now no need for the CONFIG_PCI option
> > > > if selecting m68knommu. The only m68knommu platforms that had PCI
> > > > as far as I know where those that use the comempci part.
> > >
> > > That implies I can also kill the m68k PCI code since m68knommu will
> > > never use it?
> >
> > Sure. If the FreeScale guys ever forward-port their ColdFire/MMU code to
> > current mainline, we can readd it.
>
> Patch (on top of my Hades removal patch) is below.
>
> cu
> Adrian
>
>
> <-- snip -->
>
>
> This patch removes the no longer used m68k PCI code.
>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>
Thanks! Will queue for 2.6.28, too.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/