Re: [uml-devel] [PATCH 4/6] VM: Annotate pagealloc

[Pekka Enberg]

Hi Steve,

On Wed, Sep 3, 2008 at 8:25 AM, Steve VanDeBogart
<vandebo-lkml@xxxxxxxxxxx> wrote:
>>> Index: linux-2.6.27-rc5/mm/page_alloc.c
>>> @@ -1080,6 +1081,7 @@
>>>               if (!page)
>>>                       goto failed;
>>>       }
>>> +       VALGRIND_MAKE_MEM_UNDEFINED(page_address(page), PAGE_SIZE <<
>>> order);
>>
>> No SHOUTING macros please, and I think you should just pass page and
>> order here and do the calculation elsewhere.
>
> Valgrind provides a header file that defines these annotation functions.
> For the ease of tracking changes to this header file, I've made minimal
> changes to it (just a couple lines to integrate with Kconfig).  If the
> interfaces and/or style is objectionable to the kernel community at
> large, than we will have to decide to either wrap the interface that
> Valgrind provides or modify the header and track changes manually.

That's trivially fixable by adding a wrapper for the ugly valgrind
macros and hiding that in some header file. Preferably something
similar to what the kmemcheck hooks look like so that we can also use
them in the future if we implement tracking at page allocator level
too.

                                 Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/