Re: [patch 7/8] m68k: Add missing dma_sync_single_range_for_{cpu,device}()

[Geert Uytterhoeven]

On Wed, 3 Sep 2008, Geert Uytterhoeven wrote:
> On Wed, 3 Sep 2008, Roman Zippel wrote:
> > On Wed, 3 Sep 2008, Geert Uytterhoeven wrote:
> > 
> > > Add the missing dma_sync_single_range_for_{cpu,device}(), and remove the bogus
> > > `inline' for the non-static function dma_sync_single_for_device().
> > 
> > It's not bogus, it's a hint to gcc to inline the function into the callers 
> > in the same file, but also to provide an external version.
> 
> IIRC, gcc actually complained about it. I'll check again...

| arch/m68k/include/asm/dma-mapping.h:73: warning: 'dma_sync_single_for_device' declared inline after being called
| arch/m68k/include/asm/dma-mapping.h:73: warning: previous declaration of 'dma_sync_single_for_device' was here

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/