Re: [patch 7/8] m68k: Add missingdma_sync_single_range_for_{cpu,device}()

[Adrian Bunk]

On Wed, Sep 03, 2008 at 12:59:04PM +0200, Roman Zippel wrote:
> Hi,
> 
> On Wed, 3 Sep 2008, Geert Uytterhoeven wrote:
> 
> > Add the missing dma_sync_single_range_for_{cpu,device}(), and remove the bogus
> > `inline' for the non-static function dma_sync_single_for_device().
> 
> It's not bogus, it's a hint to gcc to inline the function into the callers 
> in the same file, but also to provide an external version.

"hint" = "we force gcc"

either we want it inlined into all callers or we want one external copy.
Doing both is suboptimal.

> bye, Roman

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/