Re: [PATCH 7/9] ASoC: Blackfin: I2S CPU DAI driver

[Mark Brown]

On Thu, Sep 04, 2008 at 04:22:06PM +0800, Bryan Wu wrote:
> From: Cliff Cai <cliff.cai@xxxxxxxxxx>
> 
> Signed-off-by: Cliff Cai <cliff.cai@xxxxxxxxxx>
> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Please fix the minor issues below as incremental patches for ease of
review.

> +	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> +	case SND_SOC_DAIFMT_I2S:
> +		break;
> +	case SND_SOC_DAIFMT_LEFT_J:
> +		ret = -EINVAL;
> +		break;
> +	}

The SND_SOC_DAFIMT_LEFT_J: ought to be default: instead - there's more
DAI formats than just that.

> +	if (!bf5xx_i2s.master) {
> +	/*
> +	 * TX and RX are not independent,they are enabled at the same time,
> +	 * even if only one side is running.So,we need to configure both of
> +	 * them in advance.
> +	 *
> +	 * CPU DAI format:I2S, slave mode.
> +	 */

The indentation here is odd.  Also, is the expecation that this
configuration be done only once ever - nothing seems to clear the flag?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/