Re: [PATCH] ncurses based config

[Randy.Dunlap]

On Thu, 4 Sep 2008, Nir Tzachar wrote:

> Good morning.
> 
> Sorry for the delay, it was night here...
> 
> > Hi,
> > >
> > > On Wednesday 03 September 2008, Nir Tzachar wrote:
> > > > This patch was inspired by the kernel projects page, where an ncurses
> > > > replacement for menuconfig was mentioned (by Sam Ravnborg).
> > > >
> > > > Building on menuconfig, this patch implements a more modern look
> > interface using
> > > > ncurses and ncurses' satellite libraries (menu, panel, form). The
> > implementation
> > > > does not depend on lxdialog, which is currently distributed with the
> > kernel.
> > > >
> > > > The only change outside of nconf.c is due to a name clash: both ncurses
> > and
> > > > lkc.h define a fucntion named menu_init(). I changed the internal
> > version's
> > > > name.
> > > >
> > > > Please consider the patch for merging. Comments are appreciated.
> > >
> > > Could you please tell what kernel version is it against?
> >
> > It applies cleanly to 2.6.27-rc5-git4 FWIW.
> >
> 
> I based the patch on current git tree. Is a more stable version preferable?

No, that's fine.

> >
> > > I'm getting the following error on make nconfig (and also on make
> > menuconfig
> > > which works fine without this patch) with the current Linus' tree:
> > >
> > >   HOSTCC  scripts/kconfig/conf.o
> > >   HOSTCC  scripts/kconfig/kxgettext.o
> > >   HOSTCC  scripts/kconfig/nconf.o
> > >   HOSTCC  scripts/kconfig/zconf.tab.o
> > > scripts/kconfig/zconf.tab.c: In function ÿÿconf_parseÿÿ:
> > > scripts/kconfig/zconf.tab.c:2258: warning: implicit declaration of
> > function ÿÿmenu_initÿÿ
> > >   HOSTLD  scripts/kconfig/nconf
> > > scripts/kconfig/nconf arch/x86/Kconfig
> > > make[1]: *** [nconfig] Segmentation fault
> > > make: *** [nconfig] Error 2
> >
> > Need to change all /menu_init/ in zconf.tab.c* to /_menu_init/.
> >
> 
> I believe the patch does change these lines.

Perhaps the patch was missing some pieces then.  It does not
contain any changes to the zconf* files.

> >
> > Need to strip trailing whitespace on new source code lines.
> >
> 
> scripts/checkpatch.pl did not report anything here. Maybe git-email-send
> messed up the patch??

Too bad.

quilt reported several of those when I applied the patch.
AFAIK, git also will report that.

These lines have trailing spaces:

57:+nconf-objs  := nconf.o zconf.tab.o 
85:+HOSTLOADLIBES_nconf = -lmenu -lpanel -lform -lncurses 
86:+HOSTCFLAGS_nconf.o  = 
87:+LDFLAGS_nconf.o     = 

> > I'm seeing cyan (?) foreground on black background.  Is that the colors
> > that were planned?
> >
> 
> > Instructions are dark blue on black -- cannot read them.
> >
> 
> Well, colors were never my strong point ;) If someone can come up with a
> better color scheme I'll be more than happy to change.

-- 
~Randy