Re: [PATCH] x86: order functions in cpu/common.c andcpu/common_64.c

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxx> wrote:

> applied these patches to tip/x86/cpu:
> 
>  0a488a5: x86: move 32bit related functions together
>  01b2e16: x86: make get_mode_name of 64bit the same as 32bit
>  a0854a4: x86: make 32bit support show_msr like 64 bit
>  10a434f: x86: remove cpu_vendor_dev
>  9d31d35: x86: order functions in cpu/common.c and cpu/common_64.c v2
>  3da99c9: x86: make (early)_identify_cpu more the same between 32bit and 64 bit
>  5031088: x86: delay early cpu initialization until cpuid is done
>  5fef55f: x86: move mtrr cpu cap setting early in early_init_xxxx

hm, something in your patch series is early-crashing tip/master with 
this config:

 http://redhat.com/~mingo/misc/config-Thu_Sep__4_21_23_20_CEST_2008.bad

the early-RIP is 0xffffffff804365b0:

ffffffff8043656a <proc_bus_pci_release>:

ffffffff804365b0:       be d0 00 00 00          mov    $0xd0,%esi
ffffffff804365b5:       e8 ad 28 e7 ff          callq  ffffffff802a8e67 <kmem_cache_alloc>

fault 0xd, general protection fault. Given that it's an immediate 
constant load, something really serious happened.

i've pushed out the broken tree into tip/tmp.master.broken (havent 
updated tip/master with the breakage). I've removed the broken printk in 
kernel/resource.c that Andrew found, see commit 06e44f6af324 - so that's 
not the cause.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/