Re: [PATCH 1/3] x86: remove the NULL device hack in dma-mapping.h

From: Robert Hancock
Date: Thu Sep 04 2008 - 19:53:42 EST


FUJITA Tomonori wrote:
On Wed, 3 Sep 2008 22:01:14 +0200
Joerg Roedel <joro@xxxxxxxxxx> wrote:

On Thu, Sep 04, 2008 at 03:04:23AM +0900, FUJITA Tomonori wrote:
+static void *x86_swiotlb_alloc_coherent(struct device *dev, size_t size,
+ dma_addr_t *dma_handle, gfp_t gfp)
+{
+ if (!dev) {
+ dev = &x86_dma_fallback_dev;
+ gfp |= GFP_DMA;
+ }
This really should be checked in the generic x86 dma_alloc_coherent
function.

I don't think so. Any motherboards with the recent IOMMUs support ISA?

Probably some LPC devices on those boards..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/