Re: [PATCH] Fixing section mismatch warning .

[Peter Zijlstra]

On Tue, 2008-09-02 at 21:43 +0600, Rakib Mullick wrote:
> LD      kernel/built-in.o
> WARNING: kernel/built-in.o(.text+0x326): Section mismatch in reference
> from the function init_hrtick() to the variable
> ..cpuinit.data:hotplug_hrtick_nb.8
> The function init_hrtick() references
> the variable __cpuinitdata hotplug_hrtick_nb.8.
> This is often because init_hrtick lacks a __cpuinitdata
> annotation or the annotation of hotplug_hrtick_nb.8 is wrong.
> 
>  This patch fixes the above warning.
>  Thanks.
> 
> Signed-off-by: Md.Rakib H. Mullick (rakib.mullick@xxxxxxxxx)
> 
> --- linux-2.6.27-rc5.orig/kernel/sched.c	2008-08-31 17:07:03.000000000 +0600
> +++ linux-2.6.27-rc5/kernel/sched.c	2008-09-01 22:23:30.000000000 +0600
> @@ -1087,7 +1087,7 @@ hotplug_hrtick(struct notifier_block *nf
>  	return NOTIFY_DONE;
>  }
> 
> -static void init_hrtick(void)
> +static __init void init_hrtick(void)
>  {
>  	hotcpu_notifier(hotplug_hrtick, 0);
>  }

then, shouldn't it be __cpuinit ?

BTW - would've been nice to see sched mentioned in the topic.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/