Re: [patch 3/3] x86: io-apic - code style cleaning forsetup_IO_APIC_irqs

[Ingo Molnar]

* Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:

> So as you see it's more then enough self-solid :) So I wouldn't break 
> it 'cause of printing. If we have enough memory for bit field - we 
> could just mark there if pin is connected to irq and print connection 
> map after. Don't get me wrong please - I just don't want to overload 
> this function with additional call.

the compiler will inline that single-called function just fine, as long 
as you declare it static.

spreading printouts over several functions isnt all that bad i think. We 
could even drop the 'not connected' complication - it's evident enough 
from the fact that nothing gets printed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/