Re: [RFC:Patch: 008/008](memory hotplug) remove_pgdat() function

[Peter Zijlstra]

On Thu, 2008-07-31 at 21:04 +0900, Yasunori Goto wrote:

> +int remove_pgdat(int nid)
> +{
> +	struct pglist_data *pgdat = NODE_DATA(nid);
> +
> +	if (cpus_busy_on_node(nid))
> +		return -EBUSY;
> +
> +	if (sections_busy_on_node(pgdat))
> +		return -EBUSY;
> +
> +	node_set_offline(nid);
> +	synchronize_sched();
> +	synchronize_srcu(&pgdat_remove_srcu);
> +
> +	free_pgdat(nid, pgdat);
> +
> +	return 0;
> +}

FWIW synchronize_sched() is the wrong function to use here,
synchronize_rcu() is the right one.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/