Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol

[Yinghai Lu]

On Sat, Sep 6, 2008 at 10:09 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
>
> * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>> >     ptr = __alloc_bootmem_nopanic(total_size, max_align, 0);
>> >     if (!ptr)
>> >             panic("Can not alloc dyn_alloc\n");
>>
>> Why duplicate the panic()?  Just call __alloc_bootmem().
>
> agreed.
>
>> > #ifdef CONFIF_GENERIC_HARDIRQS
>>
>> That doesn't appear to have been very well tested?
>
> on non-genirq systems? Most likely. If then most testing they get is
> from cross-build tools. Few if any actual users.
>
>> The code has a few coding-style glitches which checkpatch can detect.
>
> yeah. Yinghai, could you please fix them?

already in tip/master and -mm
except  first one.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/