Re: [PATCH] genirq: irq_chip->startup() usage in setup_irq andset_irq_chained handler

From: Ingo Molnar
Date: Sat Sep 06 2008 - 14:37:45 EST



* Pawel MOLL <pawel.moll@xxxxxx> wrote:

> This patch clarifies usage of irq_chip->startup() callback:
>
> 1. The "if (startup) startup(); else enabled();" code in setup_irq()
> is unnecessary, as startup() falls back to enabled() via
> default callbacks, set by irq_chip_set_defaults().
>
> 2. When using set_irq_chained_handler() the startup() was never called,
> which is not good at all... Fixed. And again - when startup() is not
> defined the call will fall back to enable() than to unmask() via
> default callbacks.
>
> Signed-off-by: Pawel Moll <pawel.moll@xxxxxx>
> Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

applied the commit below to tip/genirq - thanks Pawel.

Ingo

------------->