Re: [patch 3/3] x86: io-apic - code style cleaning forsetup_IO_APIC_irqs

[Ingo Molnar]

* Maciej W. Rozycki <macro@xxxxxxxxxxxxxx> wrote:

> On Sat, 6 Sep 2008, Cyrill Gorcunov wrote:
> 
> > Ingo, how about the following approach? We don't introduce new
> > functions but rather srink the code by new printout form.
> 
>  Honestly, this one should probably use sprintf() or suchlike to avoid the
> mess of printk() calls building a line of output from pieces.  It's quite
> easy to calculate here what the maximum size of the buffer required could
> be and automatic arrays can have variable size, so no need for the hassle
> of heap management.  Calls to printk() without a trailing newline should
> be avoided where possible as it messes up logging priority if a message
> pops up from an interrupt inbetween.

hm, is it worth the trouble? This is during very early init.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/