Re: [patch 3/3] x86: io-apic - code style cleaning forsetup_IO_APIC_irqs

From: Ingo Molnar
Date: Sun Sep 07 2008 - 11:47:44 EST



* Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:

> here is an another attempt to satisfy the requirements :)
> Please review and comment if it looks better or worse now.

sigh, i think the extra buffering is clearly worse. These are early init
printks and we already do many other cases of multi-line printouts and
even KERN_CONT printouts. We have a perfectly fine built-in buffer
already: the printk buffer.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/