Re: [PATCH 01/18] lirc core device driver infrastructure

[Janne Grunau]

On Thursday 11 September 2008 20:03:00 Christoph Bartelmus wrote:
> Hi Janne,
>
> on 10 Sep 08 at 14:24, Janne Grunau wrote:
> > On Tuesday 09 September 2008 15:01:02 Christoph Hellwig wrote:
> >>> +	do {
> >>> +		if (ir->open) {
> >>> +			if (ir->jiffies_to_wait) {
> >>> +				set_current_state(TASK_INTERRUPTIBLE);
> >>> +				schedule_timeout(ir->jiffies_to_wait);
> >>> +			} else {
> >>> +				interruptible_sleep_on(
> >>> +					ir->p.get_queue(ir->p.data));
> >>> +			}
> >>
> >> No sleep on, please.  But this one should be trivial to fix
> >> anyway, by just changing this to a
> >>
> >> 	set_current_state(TASK_INTERRUPTIBLE);
> >> 	schedule();
> >>
> >> and using wake_up_process in the wakeup path.
> >
> > No driver uses the get_queue callback. So I'm inclined to just
> > remove it. Christoph, any objections?
>
> lirc_gpio is using it.
> I guess there will be no need to use lirc_gpio in future, but I'd
> like to keep this in CVS for people who still use it.

We don't have lirc_gpio in the kernel tree? And I guess there is no need 
to integrate into the kernel. I've removed it already.

Janne

> Christoph


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/