Re: [PATCH] introduce boot_printk()

[H. Peter Anvin]

Yinghai Lu wrote:
> On Tue, Sep 16, 2008 at 11:15 AM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> > Yinghai Lu wrote:
> > > you still can use
> > > pci_printk(v, KERN_PCI KERN_DEBUG "...\n");
> > >
> > > if vprintk is expanded to handle KERN_PCI and other tags...
> > > or even you could use
> > > pci_printk(v, KERN_ACPI KERN_DEBUG "...\n");
> > And the point of this, other than sheer verbosity?
>
> let every file or componet of subsystem could control the print out
> via loglevel=pci_any_name:7

pci_printk(v, KERN_ACPI KERN_DEBUG "...\n");
^^^^          ^^^^^^^^^

Not only do you have duplication, here, but inconsistency...

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/