Re: [PATCH 25/27] nilfs2: block cache for garbage collection

[JÃrn Engel]

On Mon, 15 September 2008 04:08:22 +0900, Ryusuke Konishi wrote:
> 
> This adds the cache of on-disk blocks to be moved in garbage
> collection.  The disk blocks are held with dummy inodes (called
> gcinodes), and this file provides lookup function of the dummy inodes,
> and their buffer read function.

Nice explanation.  Can you add it to the comment header at the top of
the file?  Unlike the GPL preample, it actually helps non-lawyers. ;)

Using dummy inodes is... unusual.  Why can you not use the actual inodes
those blocks belong to?  Or alternatively a single inode that simply
covers the complete physical device?

JÃrn

-- 
All models are wrong. Some models are useful.
-- George Box
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/