Re: [PATCH] IDE-TAPE NULL terminate strings.

[Sergei Shtylyov]

Hello, I wrote:

> > After updating my kernel to 2.6.26 the output for the ide-tape drive
> > during booting is garbled eg
> > ide-tape: hdd <-> ht0: Seagate <98>ß8A51|1À<81>ܺ<98>ß STT20000A rev 
> > 8A51|1À<81>ܺ<98>ß

> > This patch fixes the problem by NULL terminating the strings.

> > Regards,
> > Mark de Wever

> > PS: please CC me since I'm not subscribed.
> > PPS: there are more problems with my tapestreamer in 2.6.26 but I'll
> > post a separate message for that.

> > Signed-off-by: Mark de Wever <koraq@xxxxxxxxx>

> > diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
> > index 1bce84b..fd87b43 100644
> > --- a/drivers/ide/ide-tape.c
> > +++ b/drivers/ide/ide-tape.c
> > @@ -2354,6 +2354,10 @@ static void 
> > idetape_get_inquiry_results(ide_drive_t *drive)
> >      ide_fixstring(product_id, 18, 0);
> >      ide_fixstring(fw_rev, 6, 0);

   Hm, I see that every string variable declared there has 2 extra 
characters, and yet the author have managed to make a mistake... these extra 
chars don't seem needed.

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/