Re: [PATCH 3/3] x86/iommu: use __GFP_ZERO instead of memset forGART

[Ingo Molnar]

* Joerg Roedel <joerg.roedel@xxxxxxx> wrote:

>  #ifdef CONFIG_IOMMU_LEAK
>  	if (leak_trace) {
> -		iommu_leak_tab = (void *)__get_free_pages(GFP_KERNEL,
> +		iommu_leak_tab = (void *)__get_free_pages(GFP_KERNEL|__GFP_ZERO,
>  				  get_order(iommu_pages*sizeof(void *)));
> -		if (iommu_leak_tab)
> -			memset(iommu_leak_tab, 0, iommu_pages * 8);
>  		else
>  			printk(KERN_DEBUG
>  			       "PCI-DMA: Cannot allocate leak trace area\n");

hm, that looks broken.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/