Re: [PATCH 3/4][resubmit] TPM: rcu locking

[Serge E. Hallyn]

Quoting Rajiv Andrade (srajiv@xxxxxxxxxxxxxxxxxx):
> Reading the code again, we noticed that there's a put_device() missing
> right inside this test:

Oops.  So ignore my other comment  :)

Sorry, I'm behind on some email.

-serge

> >  	if (test_and_set_bit(0, &chip->is_open)) {
> >  		dev_dbg(chip->dev, "Another process owns this TPM\n");
> > -		rc = -EBUSY;
> > -		goto err_out;
> > +		return -EBUSY;
> >  	}
> > 
> Since this was moved to a section before.
> > -	get_device(chip->dev);
> > -
> 
> I'll submit a patch to be applied on top of this one.
> 
> Rajiv Andrade
> IBM Linux Technology Center
> Security Development
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/