Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiledas a module

From: Timur Tabi
Date: Thu Sep 25 2008 - 09:55:24 EST


Li Yang wrote:

>> -subsys_initcall(of_fsl_dma_chan_init);
>> subsys_initcall(of_fsl_dma_init);
>
> Not a critical problem. But module_init() are preferred for modules.

This was intentional. When compiled as a module, subsys_initcall becomes
module_init(). When compiled in-kernel, this code is initialized before most
drivers, so it's ready when the drivers are loaded.

> Acked-by: Li Yang <leoli@xxxxxxxxxxxxx>

Thanks.

--
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/