Re: [PATCH v5] Unified trace buffer
From: Steven Rostedt
Date: Fri Sep 26 2008 - 13:47:06 EST
On Fri, 26 Sep 2008, Linus Torvalds wrote:
>
>
> On Fri, 26 Sep 2008, Arnaldo Carvalho de Melo wrote:
> >
> > Why do you need __packed__ here? With or without it the layout is the
>From just being paranoid.
> > same:
>
> Indeed. And on some architectures 'packed' will actually mean that the
> compiler may think that it's unaligned, and then generate much worse code
> to access the fields. So if you align things anyway (and you do), then
> 'packed' is the wrong thing to do.
OK, I'm making v6 now with various cleanups. I'll nuke it on that one.
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/