Re: [PATCH -tip 2/3] Tracing/ftrace: Adapt mmiotrace to the new type of print_line

[Frédéric Weisbecker]

2008/9/26 Pekka Paalanen <pq@xxxxxx>:
> On Fri, 26 Sep 2008 17:44:07 +0200
> Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
>
>> Adapt mmiotrace to the new print_line type.
>> By default, it refuses types it doesn't support.
>> But a tracer needs to print something to the seq anyway.
>> That's why it needs to warn about unsupported types.
>>
>> Pekka if you disagree with it, please don't hesitate to tell me.
>
> Yes, I do disagree about printing stuff that doesn't belong there.
> First, I doubt printing bogus text is a right way to fix the
> early pipe EOF problem. Second, if you really have to do that,
> do it so that it obeys the mmiotrace log format specification.
> (I'd recommend a MARK entry.) The spec is in
> Documentation/tracers/mmiotrace.txt.
>
> This is just a very quick comment, and I should look at your two
> patches better. I hope to do that during the weekend.
>
> Was there supposed to be a third patch, as the subject suggests?
>
> Thanks.
>
>


No problem, I have one other option: ignoring and sleep again before
receiving another entries.
I can do another patch this week end to implement that.
The third patch only concerns the boot tracer. It relays to other
output functions.

Just tell me if you agree with the ignoring...

Thanks !
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/