Re: [PATCH git latest] drivers/net: fixing a datarace related toupdate_stats()

[Francois Romieu]

(Please Cc: netdev@xxxxxxxxxxxxxxx)

Lin Tan <tammy000@xxxxxxxxx> :
[drivers/net/pcmcia/3c589_cs.c race]
> As indicated by the following comment, a lock must be held before calling 
> function update_stats(). This rule is followed in some cases, but not in 
> others. For example, the lock is held when the function is called in function 
> el3_get_stats(), but the lock is NOT held when called in el3_close(). It can 
> cause potential data races. 

I would not bet that the irq handler does not race with el3_close()
in the first place. Could you dig it ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/