Re: [patch 2.6.27-rc7] gpiolib: request/free hooks

[David Brownell]

On Sunday 28 September 2008, Magnus Damm wrote:
> Hm, sounds like you prefer to keep pinmuxing and GPIO code separated?

Yep.

> > If you do that, be ready to provide a pinmux-only interface
> > at some point when this "piggybacking" breaks something...
> 
> In the SuperH case GPIO pin direction selection is done in the same
> way as selecting pin function. So in and out directions can be seen as
> two pin functions. And since we want to support GPIO pin direction we
> may as well support setting pin functions as well.
> 
> But maybe there are better ways to integrate it, I'm not sure.

Just don't expect the GPIO framework to address the problem of
how to configure one of those pins for a non-GPIO function.

Such pinmux problems deserve different programming interfaces.

\
> > Yeah.  Better to test-and-set the flag and then request, and backout
> > if it fails, than the other way.  Just who wrote that crap in the
> > first place?  Sigh.  (Notice it's done that way already in the code
> > path handling implicit requesting ... )
> 
> Sounds good.
> 
> > I'll send an updated patch along soonish.
> 
> Thank you!

... after I come up with a happy fix for the locking goofs;
those new methods may not be called under spinlock protection.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/