RE: [PATCH 7/7] x86: print out irq nr for msi/ht -v2

[Pallipadi, Venkatesh]

Doesn't look like this patch is doing anything with respect to "hpet compiling".
It is just adding some debug prints. I guess we need a better patch description.

Thanks,
Venki

>-----Original Message-----
>From: linux-kernel-owner@xxxxxxxxxxxxxxx
>[mailto:linux-kernel-owner@xxxxxxxxxxxxxxx] On Behalf Of Yinghai Lu
>Sent: Wednesday, September 24, 2008 11:14 PM
>To: Jesse Barnes; Len Brown; Ingo Molnar; Thomas Gleixner; H.
>Peter Anvin; Andrew Morton
>Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
>linux-acpi@xxxxxxxxxxxxxxx; Yinghai Lu
>Subject: [PATCH 7/7] x86: print out irq nr for msi/ht -v2
>
>v2: fix hpet compiling
>
>Signed-off-by: Yinghai Lu <yhlu.kernel@xxxxxxxxx>


Doesn't look like the patch below is doing anything with respect to "hpet compiling".
It is just adding some debug prints. I guess we need a different patch description.

Thanks,
Venki


>---
> arch/x86/kernel/hpet.c    |    3 +++
> arch/x86/kernel/io_apic.c |    7 +++++++
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
>diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
>index 422c577..686505a 100644
>--- a/arch/x86/kernel/hpet.c
>+++ b/arch/x86/kernel/hpet.c
>@@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_dev *dev)
>        irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
>        enable_irq(dev->irq);
>
>+       printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
>+                        dev->name, dev->irq, dev->irq);
>+
>        return 0;
> }
>
>diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c
>index 4cc9cb6..dc82397 100644
>--- a/arch/x86/kernel/io_apic.c
>+++ b/arch/x86/kernel/io_apic.c
>@@ -3355,6 +3355,9 @@ static int setup_msi_irq(struct pci_dev
>*dev, struct msi_desc *desc, int irq)
> #endif
>                set_irq_chip_and_handler_name(irq, &msi_chip,
>handle_edge_irq, "edge");
>
>+       printk(KERN_DEBUG "PCI: %s is using irq %#x aka %d for
>MSI/MSI-X\n",
>+                        pci_name(dev), irq, irq);
>+
>        return 0;
> }
>
>@@ -3587,6 +3590,7 @@ int arch_setup_hpet_msi(unsigned int irq)
>        hpet_msi_write(irq, &msg);
>        set_irq_chip_and_handler_name(irq, &hpet_msi_type,
>handle_edge_irq,
>                "edge");
>+
>        return 0;
> }
> #endif
>@@ -3683,6 +3687,9 @@ int arch_setup_ht_irq(unsigned int irq,
>struct pci_dev *dev)
>
>                set_irq_chip_and_handler_name(irq, &ht_irq_chip,
>                                              handle_edge_irq, "edge");
>+
>+               printk(KERN_DEBUG "PCI: %s is using irq %#x
>aka %d for HT\n",
>+                                pci_name(dev), irq, irq);
>        }
>        return err;
> }
>--
>1.5.6
>
>--
>To unsubscribe from this list: send the line "unsubscribe
>linux-kernel" in
>the body of a message to majordomo@xxxxxxxxxxxxxxx
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/