Re: [patch 1/2] x86: track memtype for RAM in page struct - v3

[Nick Piggin]

On Thursday 25 September 2008 01:53, Venki Pallipadi wrote:

>  /*
> + * RED-PEN:  TODO: Add PageReserved() check as well here,
> + * once we add SetPageReserved() to all the drivers using
> + * set_memory_* or set_pages_*.
> + *
> + * This will help prevent accidentally freeing pages
> + * before setting the attribute back to WB.
> + */

I'd rather we didn't add any more uses of PageReserved without a
really good reason.

At this point in time (or at least last time I looked, a year or
two ago), it isn't a whole lot of work to remove PG_reserved
completely. If the waters get muddied up again, it could require
another significant rework to remove it in future...

Thanks,
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/