Re: [PATCH -tip] sched: fix using uninilialzed rq in task_delta_exec()

From: Hiroshi Shimamoto
Date: Tue Sep 30 2008 - 12:47:01 EST


Ingo Molnar wrote:
> * Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx> wrote:
>
>> From: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>
>>
>> compiler warnings;
>>
>> CC kernel/sched.o
>> kernel/sched.c: In function 'task_delta_exec':
>> kernel/sched.c:4055: warning: unused variable 'flags'
>> kernel/sched.c:4054: warning: 'rq' is used uninitialized in this function
>>
>> calling task_delta_exec() may cause unexpected pointer access.
>
> heh, just fixed that as well, latest tip/master should have the fix.
>
> Have you seen any weirdness due to this uninitialized variable?

No I've never seen any problem yesterday.
And I didn't have much time to use tip tree yesterday:)

Today's looks good.

thanks,
Hiroshi Shimamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/