Re: [PATCH] slub: reduce total stack usage of slab_err & object_err
From: Christoph Lameter
Date: Tue Sep 30 2008 - 13:37:17 EST
Richard Kennedy wrote:
> Yes, using vprintk is better but you still have this path :
> ( with your patch applied)
>
> object_err -> slab_bug(208) -> printk(216)
> instead of
> object_err -> slab_bug_message(8) -> printk(216)
>
> unfortunately the overhead for having var_args is pretty big, at least
> on x86_64. I haven't measured it on 32 bit yet.
Really 208 bytes for a va arg parameter declaration? I expected it to be
simply a null terminated pointer list.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/