Re: [PATCH 1/1] block: installing include/linux/blktrace_api.h

[Jens Axboe]

On Wed, Oct 01 2008, Andrew Morton wrote:
> > On Wed, 24 Sep 2008 08:47:51 -0600 John Jolly <jjolly@xxxxxxxxxx> wrote:
> > From: John Jolly <jjolly@xxxxxxxxxx>
> > 
> > Added line to install include/linux/blktrace_api.h during 'make headers_install'
> > 
> > Signed-off-by: John Jolly <jjolly@xxxxxxxxxx>
> > CC: Jan Blunck <JBlunck@xxxxxxxxxx>
> > ---
> >  include/linux/Kbuild |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> > index b68ec09..f1e5fa1 100644
> > --- a/include/linux/Kbuild
> > +++ b/include/linux/Kbuild
> > @@ -41,6 +41,7 @@ header-y += baycom.h
> >  header-y += bfs_fs.h
> >  header-y += blkpg.h
> >  header-y += bpqether.h
> > +header-y += blktrace_api.h
> >  header-y += can.h
> >  header-y += cdk.h
> >  header-y += chio.h
> 
> The two basic and almost always necessary parts of a patch changelog are
> 
> a) what was changed and
> 
> b) why the change was made
> 
> Your changelog had no b), hence nobody is likely to apply the patch.

A similar patch is already merged for 2.6.28 as well.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/