Re: [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer

From: KOSAKI Motohiro
Date: Thu Oct 02 2008 - 23:41:54 EST


Hi Cristoph,

> >> At the beginning of reclaim just flush all pcp pages and then do not allow pcp
> >> refills again until reclaim is finished?
> >
> > Not entirely, some pages could get trapped there for sure. But it is
> > parallel allocations we are trying to guard against. Plus we already flush
> > the pcp during reclaim for higher orders.
>
> So we just would need to forbid refilling the pcp.
>
> Parallel allocations are less a problem if the freed order 0 pages get merged
> immediately into the order 1 freelist. Of course that will only work 50% of
> the time but it will have a similar effect to this patch.

Ah, Right.
Could we hear why you like pcp disabling than Andy's patch?

Honestly, I think pcp has some problem.
But I avoid to change pcp because I don't understand its design.

Maybe, we should discuss currect pcp behavior?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/