Re: [mmotm 02/Oct] fix buid error of hid-core

[Andrew Morton]

On Thu,  9 Oct 2008 15:45:19 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:

> Ping!

I'm in hiding until linux-next comes back.

> > Patch against: mmotm 02 Oct
> > Applied after: usb-usb-remove-warn-macro-from-usbh.patch
> > 
> > fix following buiild error
> > 
> > -------------------------
> >   CC [M]  drivers/hid/usbhid/hid-core.o
> > drivers/hid/usbhid/hid-core.c: In function 'usbhid_submit_report':
> > drivers/hid/usbhid/hid-core.c:417: error: incompatible type for argument 1 of 'dev_driver_string'
> > drivers/hid/usbhid/hid-core.c:417: error: incompatible type for argument 1 of 'dev_name'
> > drivers/hid/usbhid/hid-core.c:436: error: incompatible type for argument 1 of 'dev_driver_string'
> > drivers/hid/usbhid/hid-core.c:436: error: incompatible type for argument 1 of 'dev_name'
> > drivers/hid/usbhid/hid-core.c: In function 'usbhid_init_reports':
> > drivers/hid/usbhid/hid-core.c:568: error: incompatible type for argument 1 of 'dev_driver_string'
> > drivers/hid/usbhid/hid-core.c:568: error: incompatible type for argument 1 of 'dev_name'
> > make[3]: *** [drivers/hid/usbhid/hid-core.o] Error 1
> > make[2]: *** [drivers/hid/usbhid] Error 2
> > make[1]: *** [drivers/hid] Error 2
> > make: *** [drivers] Error 2

Attempting to remove a widely-used macro in a single patch within our
distributed development model was, frankly, short-sighted to the point
of stupidity.  I've had enough of dealing with stuff like this.  If
Stephen wants to take it on then fine.

otoh given that others need to depend on this mess to get work done, I
guess I'm forced to continue to take out the garbage.  Sigh.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/