Re: [patch] clean hex output of ftrace

[Ingo Molnar]

* Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:

> On Wed, 2008-10-08 at 17:16 -0700, Joe Perches wrote:
> > On Wed, 8 Oct 2008, Harvey Harrison wrote:
> > > From: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> > > Subject: [PATCH] ftrace: Fix inversion of hex output and use common routines
> > 
> > You're quick...
> > 
> > >  	BUG_ON(len >= HEX_CHARS);
> > 
> > I think the BUG_ON is senseless.
> > 
> 
> Agreed, it probably meant to say BUG_ON(len * 2 > HEX_CHARS -1)
> 
> But as this is only called from within a helper macro, it could be
> changed to a build-time check instead of a runtime:
> 
> From: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> Subject: [PATCH] trace: add build-time check to avoid overrunning hex buffer

applied to tip/tracing/core:

 bb86ba7: trace: add build-time check to avoid overrunning hex buffer
 32ce86f: ftrace: fix hex output mode of ftrace

thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/