Re: libata: set queue SSD flag for SSD devices

[Jens Axboe]

On Fri, Oct 10 2008, Alan Cox wrote:
> > +	ATA_ID_ROT_SPEED	= 217,
> >  	ATA_ID_PIO4		= (1 << 1),
> >  
> >  	ATA_ID_SERNO_LEN	= 20,
> > @@ -691,6 +692,11 @@ static inline int ata_id_is_cfa(const u16 *id)
> >  	return 0;
> >  }
> >  
> > +static inline int ata_id_is_ssd(const u16 *id)
> > +{
> > +	return id[ATA_ID_ROT_SPEED] == 0x01;
> > +}
> 
> This patch is buggy.
> 
> Word 217 only has a defined meaning in late revision ATA standards so a
> version check is needed. Please copy ATA patch copies to linux-ide.

Good point, I'll be sure to submit an updated patch. I did mean to copy
linux-ide, the intention was actually to pass this libata enable patch
through Jeff after testing, but it slipped through.

In this specific patch, it'll do no harm at least since I very much
doubt we'll see a false positive. And even if, the consequences wont be
dire. But it does want the version check, of course.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/