Re: [git pull] x86 updates for v2.6.28, phase #1

[H. Peter Anvin]

Vegard Nossum wrote:
> Note: If you don't want the double underscores anywhere, this patch is
> not enough.
>
> For example:
>
> > -#endif /* ASM_X86__MACH_DEFAULT__MACH_TIMER_H */
> > +#endif /* _ASM_X86_MACH_DEFAULT__MACH_TIMER_H */
>
> There are also a few non-trivial changes, which could break with a
> naÃve sed script. So I suggest to simply revert it, it's a lot safer
> than trying to patch it up in the last minute.
>
> I'm obviously also sorry for causing this problem in the first place... *blush*

Double underscores aren't the problem per se, the problem is having 
changes _ASM_X86_ to ASM_X86__ and therefore violating the namespace.

That being said, I don't personally like the double underscores.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/