Re: PATCH 10/8]linux-usb: To support more Huawei data card productIDs,fix kernel 2.6.27-rc7

[Alan Stern]

On Sat, 11 Oct 2008, Franko Fang wrote:

> Dear Greg and Alan,
> 
> Well, OK, but I will change it as follows:
>  
>   result = usb_stor_control_msg(us, us->send_ctrl_pipe,
>            USB_REQ_SET_FEATURE,
>            USB_TYPE_STANDARD | USB_RECIP_DEVICE,
>            0x01, 0x0, NULL, 0x0, 1000);
> 
> Because the parameters of USB_REQ_SET_FEATURE, USB_TYPE_STANDARD and
> USB_RECIP_DEVICE are all Hex, so I want to keep my other parameters
> to be consistant with them.

Actually they aren't hex; they are expressions using pre-processor
macros.  However the value and index arguments are hex (0x01 and 0x0);
they could be changed too.

> And I see the same using with me in the kernel. Such as the code of
> the function usb_stor_euscsi_init in initializers.c file.

It doesn't really matter.  If it were up to me, I'd change the code in 
usb_stor_euscsi_init also.

> Is this changing can be accepted by you? 

Yes.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/