Re: [update5] [PATCH] init: bzip2 or lzma -compressed kernels andinitrds

[H. Peter Anvin]

Alain Knaff wrote:
> So, leaving out the x86-specific change
> (arch/x86/boot/compressed/misc.c) in the first change, would force to
> leave that change out of lib/inflate.c as well (or else, the
> above-listed items would be doubly defined). But, if I left out these
> changes of lib/inflate.c, I'd need to leave them out of and
> init/do_mounts_rd.c and init/initramfs.c too (or else the above-listed
> items would not be defined at all in that situation). Can you suggest a
> solution? I could theoretically break that dependency chain using an
> #ifdef (as was the case until patch 3), but apparently #ifdef's are
> highly frowned upon. Or was it just the name of the ifdef ("NEW_CODE")
> that you objected to? Another option would be to (temporarily) keep 2
> copies of lib/inflate.c around, but somehow that doesn't feel right.
>
> So can you suggest some way out of the situation?

Temporarily leaving two copies would work, as would be leaving in an 
#ifdef as long as it is gone by the end of the patch series.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/