Re: [PATCH] pata_of_platform: fix no irq handling

From: Jeff Garzik
Date: Mon Oct 13 2008 - 09:27:36 EST


Tejun Heo wrote:
Anton Vorontsov wrote:
When no irq specified the pata_of_platform fills the irq_res with -1,
which is wrong to do for two reasons:

1. By definition, 'no irq' should be IRQ 0, not some negative integer;
2. pata_platform checks for irq_res.start > 0, but since irq_res.start
is unsigned type, the check will be true for `-1'.

Reported-by: Steven A. Falco <sfalco@xxxxxxxxxx>
Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>

applied to #tj-upstream (will soon be sent upstream)

I have returned! muhahahahahaha....


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/