Re: [PATCH] x86: split e820 reserved entries record to late v4 - fix v7

[Tony Luck]

On Thu, Sep 4, 2008 at 12:22 PM, Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
> On Thu, Sep 4, 2008 at 12:16 PM, Andrew Morton
> <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>> On Thu, 4 Sep 2008 21:04:57 +0200
>> Ingo Molnar <mingo@xxxxxxx> wrote:
>>
>>> +             printk(KERN_DEBUG "    __reserve_region_with_split: (%s) [%llx, %llx], res: (%s) [%llx, %llx]\n",
>>> +                      conflict->name, conflict->start, conflict->end,
>>> +                      name, start, end);
>>
>> start and end have type resource_size_t.  Such types CANNOT be printed
>> unless cast to a known type.
>>
>> Because there is a %s following an incorrect %lld, the above code will
>> crash the machine.
>
> should just remove those lines.

This didn't happen.  These lines are still in the version that went into
Linus' tree over the weekend for 2.6.28.  On the ia64 build they spit
out a bunch of warnings:

kernel/resource.c:554: warning: format '%llx' expects type 'long long
unsigned int', but argument 3 has type 'resource_size_t'

Ditto for args 4, 6 and 7 on the same line.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/