Re: [PATCH] Fix broken debug output reserve_region_with_split()

From: H. Peter Anvin
Date: Mon Oct 13 2008 - 22:58:09 EST


Benjamin Herrenschmidt wrote:

I really think Linus' solution (add a resource printf modifier, that can contain the whole format) is much better.

I agree. In fact I may even have a patch somewhere for that.

It has to be a pointer tho, thus what do we want ? Something that takes
a pointer to a resource_size_t or to a whole struct resource ? In the
later case, do we want to print the whole flags too ?


Linus already posted a patch. He took a struct resource
and printed it as a range. I pointed out that we should use the flags to determine formatting options, e.g. I/O space is only 16 bits on x86.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/