Re: [RFC PATCH 4/5] hvc_console: Add tty window resizing

From: Alan Cox
Date: Tue Oct 14 2008 - 05:51:37 EST


> + hp = container_of(work, struct hvc_struct, tty_resize);
> + if (!hp || !hp->tty)
> + return;

What locks hp->tty here, it can go NULL after the test on a hangup it
seems ?

> + * hvc_resize() - Update terminal window size information.
> + * @hp: HVC console pointer
> + * @ws: Terminal window size structure

See tty_do_resize() for all of this stuff in the latest git. If you can't
use tty_do_resize from your work queue then please let me know why as I'd
like everyone to be using one abstraction.

We also now have a "resize" operation for devices that want to react to a
resize from TIOCSWINSZ
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/