Re: GIT head no longer boots on x86-64

[Linus Torvalds]

On Wed, 15 Oct 2008, Jiri Slaby wrote:
> 
> Users usually do
> is_vmalloc_addr(a) ? vfree(a) : kfree(a);
> Even there it makes more sense to me.

Umm. No it doesn't.

That is exactly _wh7y_ "is_vmalloc_addr()" exists. But we sure as hell 
don't ever want to trigger on modules for that.

If you think that "is_vmalloc_addr()" should trigger for any kernel 
virtual address, why not just make it do so, then? And _name_ it so.

Names are important. In fact, naming is often _more_ important than the 
implementation is. And that means that the implementation should follow 
the naming, or the implementation is wrong.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/