Re: [PATCH] Add hierarchical accounting to cpu accountingcontroller

From: KAMEZAWA Hiroyuki
Date: Sun Oct 26 2008 - 21:17:44 EST


On Sat, 25 Oct 2008 08:38:52 -0700
"Paul Menage" <menage@xxxxxxxxxx> wrote:

> On Fri, Oct 24, 2008 at 11:01 PM, Bharata B Rao
> <bharata@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > Reported-by: Srivatsa Vaddagiri <vatsa@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Bharata B Rao <bharata@xxxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Paul Menage <menage@xxxxxxxxxx>
>
> So in technical terms this patch looks fine now. There's still the
> question of whether it's OK to change the existing API, since it's
> been in the kernel in its currently (non-hierarchical) form for
> several releases now.
>
Hmm..how about having 2 params as "aggregated usage" and "private usage" ?

cpuacct.usage.
cpuacct.all_subtree_usage.

heavy ?

-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/