Re: [PATCH 2/2] x86: replace BIO_VMERGE_BOUNDARY withBIOVEC_PHYS_MERGEABLE

From: FUJITA Tomonori
Date: Mon Oct 27 2008 - 00:03:19 EST


On Fri, 24 Oct 2008 13:59:06 -0700
Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> The bio common code no longer uses BIO_VMERGE_BOUNDARY, so replace it
> with BIOVEC_PHYS_MERGEABLE. Also make iommu_bio_merge a boolean
> rather than a size, as befits its use.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> Cc: Jens Axboe <jens.axboe@xxxxxxxxxx>

This doesn't look correct.

The block layer always done the physical merge if possible. We don't
provide any kernel parameter to disable it.

The iommu_bio_merge parameter had been used to enable the virtual
merge. As I wrote, the virtual merge feature was completely
removed. Effectively, the iommu_bio_merge parameter is meaningless
now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/