Re: [PATCH] ibmpex: trivial endian annotation in extract_datahelper

From: Harvey Harrison
Date: Mon Oct 27 2008 - 15:31:50 EST


On Mon, 2008-10-27 at 11:32 -0700, Darrick J. Wong wrote:
> On Fri, Oct 24, 2008 at 04:44:58PM -0700, Harvey Harrison wrote:
> > This helper is used in few enough locations that open-coding it
> > at the call sites may be better than the helper.
>
> I'm not sure how this comment relates to the diff.
>

I was referring to the extract_data helper inline, it's only used ~5
times and doesn't add much (IMO) over just opencoding it.

Cheers,

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/