Re: [PATCH] fix comile error of hdpuftrs

[Mariusz Kozlowski]

Hi,

> > drivers/misc/hdpuftrs/hdpu_nexus.c:118: error: expected identifier or '(' before 'return'
> > drivers/misc/hdpuftrs/hdpu_nexus.c:119: error: expected identifier or '(' before '}' token
> > 
> > Signed-off-by: Mariusz Kozlowski <m.kozlowski@xxxxxxxxxx>
> > 
> > --- a/drivers/misc/hdpuftrs/hdpu_nexus.c
> > +++ b/drivers/misc/hdpuftrs/hdpu_nexus.c
> > @@ -113,7 +113,6 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
> >  	if (!hdpu_chassis_id)
> >  		printk(KERN_WARNING "sky_nexus: "
> >  		       "Unable to create proc dir entry: sky_chassis_id\n");
> > -	}
> > 
> >  	return 0;
> >  }
> 
> This has been broken since 2.6.26.
> 
> Nobody noticed because there is no way of enabling CONFIG_HDPU_FEATURES
> in Kconfig.  I wonder what's up with that.

Yup. I used simple script to find the brace imbalance. Then I tried to compile it with
make drivers/misc/hdpuftrs/hdpu_nexus.o to verify this.

	Mariusz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/