Re: [PATCH 2/2] w35und: plug memory leak in wbsoft_tx()

[Pavel Machek]

On Tue 2008-10-28 23:08:50, Pekka Enberg wrote:
> On Tue 2008-10-28 00:14:38, Pekka J Enberg wrote:
> >> From: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> >>
> >> There's no reason to duplicate the skb in wbsoft_tx() and leak GFP_ATOMIC
> >> memory as the contents are copied to ->TxBuffer in MdxTx() anyway before
> >> MLMESendFrame() returns.
> 
> On Tue, Oct 28, 2008 at 9:32 PM, Pavel Machek <pavel@xxxxxxx> wrote:
> > Acked-by: Pavel Machek <pavel@xxxxxxx>
> >
> > ...but I guess I should test the this after it hits the mainline...
> 
> For sure. I'm bit surprised no one noticed this before as it seems to
> be leaking memory for every transmitted frame...

Well, I'm not quite surprised.  I noticed the driver stops working
after a while, but at that point it was a small miracle that it worked
at all...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/