Re: [PATCH][RFC] x86: add non x86 build configuration

From: Ingo Molnar
Date: Thu Oct 30 2008 - 16:58:19 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

>
> On Thu, 30 Oct 2008, Ingo Molnar wrote:
>
> >
> > * Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > One important detail: could you please flip around the modality of the
> > option? Right now it's CONFIG_SIMULATE_NON_X86_CONFIGURATION, and that
> > will be set by allyesconfig. But it has the exact opposite effect of
> > an "all yes" config.
>
> Hmm, I made it a choice, with the "Normal Config" as default, so
> that allyesconfig will not set it. Does it get set for you when you
> do an allyesconfig? I had to do the following:

hm, indeed.

Still ... the Kconfig glue looks a bit weird - it's almost never a
good idea to put 'NOT' (or any other logic operator) into a config
name. Why not make this CONFIG_STANDARD_X86_FEATURES and allow it to
be disabled when CONFIG_EMBEDDED is enabled? This way it's not just a
debug thing but also a kernel sizing feature.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/