Re: [PATCH] el3_common_init() should be __devinit, not __init

From: Linus Torvalds
Date: Sun Nov 02 2008 - 13:15:35 EST




On Sat, 1 Nov 2008, Sam Ravnborg wrote:
>
> For cpuinit/cpuexit the gain turned out to be minimal.

Quite frankly, I'm not convinced.

Yeah, yeah, most distro's end up always enabling CPU hotplug due to
suspend/resume, but:

- desktop PC's aren't where most memory pressures are anyway

- on UP, CONFIG_HOTPLUG_CPU isn't on even if you do have suspend/resume

- we should still care about embedded devices, and while some of them are
growing up (and having SMP and not caring about a few tens of kB of
memory), I don't think that's a valid argument for the other ones.

So. I'd rather we try to keep our init sections, and continue to spend
effort on fixing them. If at all possible.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/